PP-12444 cypress test confirm org details stripe setup task

alphagov · Dec 6, 2024 · c63624d · c63624d
1 parent 0165b53
commit c63624d
Show file tree

Hide file tree

Showing 8 changed files with 339 additions and 32 deletions.
diff --git a/app/services/stripe-details.service.js b/app/services/stripe-details.service.js
@@ -146,7 +146,7 @@ const updateStripeDetailsUploadEntityDocument = async (service, account, file) =
 }
 
 /**
- * Updates Stripe account director for the given service and account type
+ * Updates Stripe account organisation name and address for the given service and account type
  * @param {GatewayAccount} account
  * @param {GOVUKPayService} service
  * @param {StripeOrganisationDetailsParams} newOrgDetails

diff --git a/...cypress/integration/simplified-account/service-settings/stripe-details/bank-details.cy.js b/...cypress/integration/simplified-account/service-settings/stripe-details/bank-details.cy.js
@@ -73,7 +73,7 @@ describe('Stripe details settings', () => {
     describe('Completed', () => {
       beforeEach(() => {
         setStubs({}, [
-          stripeAccountSetupStubs.getServiceAndAccountTypeStripeSetupSuccess({
+          stripeAccountSetupStubs.getStripeSetupProgressByServiceExternalIdAndAccountType({
             serviceExternalId: SERVICE_EXTERNAL_ID,
             accountType: LIVE_ACCOUNT_TYPE,
             bankAccount: true
@@ -89,7 +89,7 @@ describe('Stripe details settings', () => {
     describe('Not yet started', () => {
       beforeEach(() => {
         setStubs({}, [
-          stripeAccountSetupStubs.getServiceAndAccountTypeStripeSetupSuccess({
+          stripeAccountSetupStubs.getStripeSetupProgressByServiceExternalIdAndAccountType({
             serviceExternalId: SERVICE_EXTERNAL_ID,
             accountType: LIVE_ACCOUNT_TYPE
           })
@@ -119,7 +119,7 @@ describe('Stripe details settings', () => {
       describe('When inputting bank details', () => {
         beforeEach(() => {
           setStubs({}, [
-            stripeAccountSetupStubs.getServiceAndAccountTypeStripeSetupSuccess({
+            stripeAccountSetupStubs.getStripeSetupProgressByServiceExternalIdAndAccountType({
               serviceExternalId: SERVICE_EXTERNAL_ID,
               accountType: LIVE_ACCOUNT_TYPE
             })
@@ -192,7 +192,7 @@ describe('Stripe details settings', () => {
       describe('When submitting valid bank details', () => {
         beforeEach(() => {
           setStubs({}, [
-            stripeAccountSetupStubs.getServiceAndAccountTypeStripeSetupSuccess({
+            stripeAccountSetupStubs.getStripeSetupProgressByServiceExternalIdAndAccountType({
               serviceExternalId: SERVICE_EXTERNAL_ID,
               accountType: LIVE_ACCOUNT_TYPE
             }),
@@ -210,7 +210,7 @@ describe('Stripe details settings', () => {
               serviceExternalId: SERVICE_EXTERNAL_ID,
               accountType: LIVE_ACCOUNT_TYPE
             }),
-            stripeAccountSetupStubs.getServiceAndAccountTypeStripeSetupSuccess({
+            stripeAccountSetupStubs.getStripeSetupProgressByServiceExternalIdAndAccountType({
               serviceExternalId: SERVICE_EXTERNAL_ID,
               accountType: LIVE_ACCOUNT_TYPE,
               bankAccount: true

diff --git a/...press/integration/simplified-account/service-settings/stripe-details/company-number.cy.js b/...press/integration/simplified-account/service-settings/stripe-details/company-number.cy.js
@@ -73,7 +73,7 @@ describe('Stripe details settings', () => {
     describe('Completed', () => {
       beforeEach(() => {
         setStubs({}, [
-          stripeAccountSetupStubs.getServiceAndAccountTypeStripeSetupSuccess({
+          stripeAccountSetupStubs.getStripeSetupProgressByServiceExternalIdAndAccountType({
             serviceExternalId: SERVICE_EXTERNAL_ID,
             accountType: LIVE_ACCOUNT_TYPE,
             companyNumber: true
@@ -89,7 +89,7 @@ describe('Stripe details settings', () => {
     describe('Not yet started', () => {
       beforeEach(() => {
         setStubs({}, [
-          stripeAccountSetupStubs.getServiceAndAccountTypeStripeSetupSuccess({
+          stripeAccountSetupStubs.getStripeSetupProgressByServiceExternalIdAndAccountType({
             serviceExternalId: SERVICE_EXTERNAL_ID,
             accountType: LIVE_ACCOUNT_TYPE
           })
@@ -119,7 +119,7 @@ describe('Stripe details settings', () => {
       describe('When inputting a company registration number', () => {
         beforeEach(() => {
           setStubs({}, [
-            stripeAccountSetupStubs.getServiceAndAccountTypeStripeSetupSuccess({
+            stripeAccountSetupStubs.getStripeSetupProgressByServiceExternalIdAndAccountType({
               serviceExternalId: SERVICE_EXTERNAL_ID,
               accountType: LIVE_ACCOUNT_TYPE
             })
@@ -158,7 +158,7 @@ describe('Stripe details settings', () => {
       describe('When selecting yes and submitting a company number', () => {
         beforeEach(() => {
           setStubs({}, [
-            stripeAccountSetupStubs.getServiceAndAccountTypeStripeSetupSuccess({
+            stripeAccountSetupStubs.getStripeSetupProgressByServiceExternalIdAndAccountType({
               serviceExternalId: SERVICE_EXTERNAL_ID,
               accountType: LIVE_ACCOUNT_TYPE
             }),
@@ -176,7 +176,7 @@ describe('Stripe details settings', () => {
               serviceExternalId: SERVICE_EXTERNAL_ID,
               accountType: LIVE_ACCOUNT_TYPE
             }),
-            stripeAccountSetupStubs.getServiceAndAccountTypeStripeSetupSuccess({
+            stripeAccountSetupStubs.getStripeSetupProgressByServiceExternalIdAndAccountType({
               serviceExternalId: SERVICE_EXTERNAL_ID,
               accountType: LIVE_ACCOUNT_TYPE,
               companyNumber: true
@@ -206,7 +206,7 @@ describe('Stripe details settings', () => {
       describe('When selecting no and completing the task', () => {
         beforeEach(() => {
           setStubs({}, [
-            stripeAccountSetupStubs.getServiceAndAccountTypeStripeSetupSuccess({
+            stripeAccountSetupStubs.getStripeSetupProgressByServiceExternalIdAndAccountType({
               serviceExternalId: SERVICE_EXTERNAL_ID,
               accountType: LIVE_ACCOUNT_TYPE
             }),
@@ -221,7 +221,7 @@ describe('Stripe details settings', () => {
               serviceExternalId: SERVICE_EXTERNAL_ID,
               accountType: LIVE_ACCOUNT_TYPE
             }),
-            stripeAccountSetupStubs.getServiceAndAccountTypeStripeSetupSuccess({
+            stripeAccountSetupStubs.getStripeSetupProgressByServiceExternalIdAndAccountType({
               serviceExternalId: SERVICE_EXTERNAL_ID,
               accountType: LIVE_ACCOUNT_TYPE,
               companyNumber: true