PP-11681 Apply suggested changes following review comments

- Pick up baseUrl from options parameter if present otherwise use default.
- Uncomment baseUrl test to test for the above.

app/services/clients/ledger.client.js

@@ -34,7 +34,8 @@ const transaction = async function transaction (id, gatewayAccountId, options =
 }
 
 const transactionWithAccountOverride = async function transactionWithAccountOverride (id, options = {}) {
-  const url = urlJoin(defaultOptions.baseUrl,'/v1/transaction', id)
+  const baseUrl = options.baseUrl ? options.baseUrl : defaultOptions.baseUrl
+  const url = urlJoin(baseUrl,'/v1/transaction', id)
   this.client = new Client(defaultOptions.service)
   const fullUrl = `${url}?override_account_id_restriction=true`
   configureClient(this.client, fullUrl)

app/services/clients/ledger.client.test.js

@@ -121,8 +121,7 @@ describe('Ledger client', () => {
 
       await ledgerClient.transactionWithAccountOverride('id', { baseUrl: 'https://example.com' })
 
-      expect(configureSpy.getCall(0).args[0]).to.equal('http://127.0.0.1:8006/v1/transaction/id?override_account_id_restriction=true')
-      // expect(configureSpy.getCall(0).args[0]).to.equal('https://example.com/v1/transaction/id?override_account_id_restriction=true')
+      expect(configureSpy.getCall(0).args[0]).to.equal('https://example.com/v1/transaction/id?override_account_id_restriction=true')
     })
   })