Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-11756 Update page as digital wallets are now live #688

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

alanmaddrell
Copy link
Contributor

Removed outdated references and tidied up text for style

Removed outdated references and tidied up text for style
Copy link
Contributor

@alexbishop1 alexbishop1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks great. One thing about the punctuation. It looks the linter does not like the way the file is formatted — a developer should be able to help you fix that.


<p class="govuk-body">Any user with Apple Pay or Google Pay enabled can make payments on your service in seconds.</p>
<p class="govuk-body">Because Apple Pay and Google already have users details, they don’t have to fill them in again on GOV.UK&nbsp;Pay. They simply have to:</p>
<p class="govuk-body">Because Apple Pay and Google already have users' details, they do not have to fill them in again on GOV.UK&nbsp;Pay. They just have to:</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this apostrophe (and the others) be curly — so rather than '?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've hopefully fixed that now. Is that everything?

replaced straight quote ' with curly quote ’ in content so it renders properly (hopefully)
alexbishop1
alexbishop1 previously approved these changes Nov 1, 2023
Copy link
Contributor

@alexbishop1 alexbishop1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m happy but the linter isn’t. Grab a developer (who has a development environment set up!) to help figure that out.

@stephencdaly stephencdaly changed the title Update page as digital wallets are now live PP-11756 Update page as digital wallets are now live Nov 2, 2023
@stephencdaly
Copy link
Contributor

@alexbishop1 I've fixed the build issue. Could you re-approve please

Copy link
Contributor

@james-peacock-gds james-peacock-gds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james-peacock-gds james-peacock-gds merged commit 9b8b114 into master Nov 3, 2023
2 checks passed
@james-peacock-gds james-peacock-gds deleted the alanmaddrell-patch-1 branch November 3, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants