PP-12021 Upgrade to DS v5 with CSP change #3907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iqbalgds
commented
Sep 18, 2024
iqbalgds
commented
- Going up to v5.6.
- Updated the code as per the release notes from the design system: https://github.com/alphagov/govuk-frontend/releases
- Remove the cookie banner code & analytics code
- This is old and no longer required.
- To get it working with DSv5 would have required work on the JS.
- Decided to just remove it.
- Update CSP to allow a manifest.json from 'self'.
- Going up to v5.6. - Updated the code as per the release notes from the design system: https://github.com/alphagov/govuk-frontend/releases - Remove the cookie banner code & analytics code - This is old and no longer required. - To get it working with DSv5 would have required work on the JS. - Decided to just remove it. - Update CSP to allow a manifest.json from 'self'.
iqbalgds
force-pushed
the
pp-12021-add-dsv5-with-csp-change
branch
from
e9f95c8 to
9d93ad3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.