Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pp 12021 upgrade to dsv5 #3903

Merged
merged 1 commit into from
Sep 17, 2024
Merged

pp 12021 upgrade to dsv5 #3903

merged 1 commit into from
Sep 17, 2024

Conversation

iqbalgds
Copy link
Contributor

@iqbalgds iqbalgds commented Sep 16, 2024

  • Going up to v5.6.
  • Updated the code as per the release notes from the design system:
    https://github.com/alphagov/govuk-frontend/releases
  • Remove the cookie banner code
    • This is old and no longer required.
    • To get it working with DSv5 would have required work on the JS.
    • Decided to just remove it.
  • Cleaned up some unused JS analytics code that is no longer required.

@iqbalgds iqbalgds force-pushed the pp-12021-upgrade-to-dsv5 branch 2 times, most recently from 1898e9e to 6834844 Compare September 16, 2024 13:11
@iqbalgds iqbalgds marked this pull request as draft September 16, 2024 13:12
@iqbalgds iqbalgds force-pushed the pp-12021-upgrade-to-dsv5 branch from 6834844 to c4b13bf Compare September 16, 2024 13:23
- Going up to v5.6.
- Updated the code as per the release notes from the design system:
  https://github.com/alphagov/govuk-frontend/releases
- Remove the cookie banner code & analytics code
  - This is old and no longer required.
  - To get it working with DSv5 would have required work on the JS.
  - Decided to just remove it.
@iqbalgds iqbalgds force-pushed the pp-12021-upgrade-to-dsv5 branch from c4b13bf to d181733 Compare September 17, 2024 08:43
Copy link
Contributor

@marcotranchino marcotranchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍
Tested locally and it all works fine, with the expected changes 🚀 ✨

1
2
3
4
5

@iqbalgds iqbalgds marked this pull request as ready for review September 17, 2024 09:59
@iqbalgds iqbalgds merged commit c94322a into master Sep 17, 2024
11 checks passed
@iqbalgds iqbalgds deleted the pp-12021-upgrade-to-dsv5 branch September 17, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants