Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-10104 remaining payment page validation bug #3898

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

hjvoid
Copy link
Contributor

@hjvoid hjvoid commented Aug 28, 2024

WHAT

Fixing same errors appearing multiple times after focus shifts to next item.

HOW

  1. Submit an empty form.
  2. See error messages above both inputs as well as in the summary fields above.
  3. Fill out a field, e.g. the card number field, with valid data.
  4. Tab out of the field to go to the next.
  5. There should now not be an error message above the data field and the corresponding error message should not be in the error summary at the top of the page.

Screenshot 2024-08-28 at 10 30 56
Screenshot 2024-08-28 at 10 31 15
Screenshot 2024-08-28 at 10 31 31

N.B. Will squash on merging.

@hjvoid hjvoid force-pushed the PP-10104_remaining_payment_page_validation_bug branch 2 times, most recently from 5c3ff98 to 32794f9 Compare August 28, 2024 10:03
iqbalgds
iqbalgds previously approved these changes Aug 30, 2024
@hjvoid hjvoid force-pushed the PP-10104_remaining_payment_page_validation_bug branch from 32794f9 to 3073a91 Compare September 17, 2024 16:07
@hjvoid hjvoid force-pushed the PP-10104_remaining_payment_page_validation_bug branch from 3073a91 to 09b2815 Compare September 19, 2024 12:43
@hjvoid hjvoid merged commit bbce4fc into master Sep 20, 2024
11 checks passed
@hjvoid hjvoid deleted the PP-10104_remaining_payment_page_validation_bug branch September 20, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants