[deploying to test only] PP-12853 Update apple pay merchant validation to use Axios #3864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, we are removing the use of `requestretry` from the Merchant Validation Controller which currently uses this module. We are replacing it by using Axios directly. Note that the previous attempted did not pass our QA on the test environment[1]. Further information in Jira[2]. [1] #3862 [2] https://payments-platform.atlassian.net/browse/PP-12853
marcotranchino
changed the title
marcotranchino
changed the title
iqbalgds
approved these changes
Jul 19, 2024
marcotranchino
deleted the
pp-12853-retry-update-to-applepay-merchant-validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we are removing the use of
requestretryfrom the Merchant Validation Controller which currently uses this module.We are replacing it by using Axios directly.
Note that the previous attempted did not pass our QA on the test environment[1].
Tests on the local environment are successful, so we are adding logs for the test environment.
Further information in Jira[2].
[1]
#3862
[2]
https://payments-platform.atlassian.net/browse/PP-12853