Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-11682 Fix admin client PACT test #3843

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

iqbalgds
Copy link
Contributor

@iqbalgds iqbalgds commented Jun 5, 2024

  • These tests were not running properly, they were using a timeout and inconsistent with the other PACT test.
  • Therefore, removed the timeout and made it consistent.

@iqbalgds iqbalgds force-pushed the pp-11682-fix-admin-client-tests branch 2 times, most recently from 2723a24 to 400644e Compare June 10, 2024 19:27
- These tests were not running properly, they were using a timeout
  and inconsistent with the other PACT test.
- Therefore, removed the timeout and made it consistant with other
  PACT tests.
@iqbalgds iqbalgds force-pushed the pp-11682-fix-admin-client-tests branch from 400644e to fe68717 Compare June 10, 2024 19:30
Copy link
Contributor

@hjvoid hjvoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎

@iqbalgds iqbalgds merged commit 1fab19c into master Jun 11, 2024
11 checks passed
@iqbalgds iqbalgds deleted the pp-11682-fix-admin-client-tests branch June 11, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants