Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-11682 Add pact test for temp connector Axios client #3828

Merged

Conversation

iqbalgds
Copy link
Contributor

  • First of many PRs, where we are copying an existing PACT test and modifying it for the new connector Axios client.

@iqbalgds iqbalgds changed the title PP-11682 Add pach test for temp connector Axios client PP-11682 Add pact test for temp connector Axios client May 10, 2024
- First of many PRs, where we are copying an existing PACT
  test and modifying it for the new connector Axios client.
@iqbalgds iqbalgds force-pushed the pp-11682-add-pact-test-for-temp-connector-axios-client branch from 89e4cb5 to f61ecdc Compare May 10, 2024 13:38
Copy link
Contributor

@marcotranchino marcotranchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the guided review! :)
LGTM! 👍

@iqbalgds iqbalgds merged commit d7c75a3 into master May 10, 2024
12 checks passed
@iqbalgds iqbalgds deleted the pp-11682-add-pact-test-for-temp-connector-axios-client branch May 10, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants