PP-11682 Add the new connector axios client #3827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adding this so that we can slowly transiton everything to this new version of the connector client using Axios. - At the moment, nothing is using this for now. - This is the first PR of many. - In the following PRs, plan to add updated unit tests. - Then transition the controllers to start using this new connector Axios client. - Once everything has transitioned over, the old connector client will be removed.
iqbalgds
force-pushed
the
pp-11682-add-temp-connector-axios-base-client
branch
from
0c5df0e to
a0ddb9c
Compare
marcotranchino
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of many PRS that is breaking up the large PR created to update update the connector client to use Axios:
#3824
Best way to see the differences, is by comparing this file to the changes made to it in the large PR:
https://github.com/alphagov/pay-frontend/pull/3824/files#diff-0a8d6b0be878b39296cfff51f4a3c04eef6f05c5a39740158c1f2a4e86001190
Might be easier to pair for a bit to explain this better.