Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-11463 Fix Google pay description dialog bug #3685

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

iqbalgds
Copy link
Contributor

  • When the payment reference is long and the Google pay dialog appears, then it does not show the add button. Which the user needs to add contact information.
  • This is a bug with Google chrome - it does not wrap the payment description text. So its pushes the button too wide so it is not visible.
  • This PR truncates the payment description if it is too long when setting up the Google payment.

- When the payment reference is long and the Google pay dialog appears,
  then it does not show the `add` button.  Which the user needs to add
  contact information.
- This is a bug with Google chrome - it does not wrap the payment description text.
  So its pushes the button too wide so it is not visible.
- This PR truncates the payment description if it is too long when setting up the
  Google payment.
@iqbalgds iqbalgds force-pushed the pp-11463-google-pay-long-description branch from 63ff7d2 to 56afc1b Compare September 20, 2023 16:07
Copy link
Contributor

@stephencdaly stephencdaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iqbalgds iqbalgds merged commit 06315f6 into master Sep 22, 2023
5 checks passed
@iqbalgds iqbalgds deleted the pp-11463-google-pay-long-description branch September 22, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants