[DO NOT MERGE] Update search dashboard #165
Conversation
- Amend styles (larger copy, more spacing, black background and flex layout) - Add 'users on GOV.UK in the last 24 hours' column - Add footer logo - Remove 'popular' and 'recently published' columns
There was a problem hiding this comment.
Nice work! Similar to the other dashboard PR I haven't delved too deeply into the code - I've primarily checked that everything looks okay (which it indeed does!). Although it looks like we may have a similar issue (not sure if it's an issue though tbh) of blank space beneath the live searches on the portrait 48-inch screen - I wonder if there'd be any mileage in increasing the size of the container a bit? Maybe 25% so we take up a bit more space but not so much that it becomes overwhelming? What do you think?
I've also left a couple of comments/questions but nothing major 👍
| trafficYesterday.$el = $('#traffic-count-yesterday'); | ||
|
|
||
| trafficYesterday.reload(); | ||
| // window.setInterval(trafficYesterday.reload, 30e3); |
There was a problem hiding this comment.
Nitpick: potential rogue comment here? I may be getting too nitpicky here though, especially if this is prototypal code, so feel free to ignore this one
There was a problem hiding this comment.
This code updates the "users in the last 30 minutes" value every 30 minutes. However, since the value represents users from the last day, not 30 minutes, this would need to be changed so I've modified it to run once per day using the following code:
window.setInterval(myObj.reload, 86400000);
This change triggers the update every 24 hours. Whether this change is necessary probably depends on whether the dashboards will be displayed on subsequent days after a visit. If they are, we'll want the data to stay up-to-date.
Yep, that looks a bit odd on the larger screen. I've modified the number of results from 20 to 48 (which seems to fill the screen). |
There was a problem hiding this comment.
This looks great, awesome work 🎉 Just spotted one thing - I think the latest commit has introduced a UI quirk where the logo "bounces":
live-search-2.mov
Things seemed to be looking pretty good for me in the penultimate commit though:
live-search-1.mov
Would it be possible to reinstate the styles/behaviour seen in the video immediately above?
Also got a couple of other questions:
- Are we thinking of keeping this code on its own branch and deploying the branch to Heroku in order to preserve
main? In which case I believe we wouldn't want to merge this? - If we do want to merge this then I guess one concern might be needing to prevent anything else from being merged into
mainso nothing changes our dashboard. Having said that, this repository is hardly ever changed (prior to Guilhem's revival of this repository on 16th December, the last commit was in July and that was to archive it) so perhaps we don't need to be too worried
jon-kirwan
changed the title
Yep, that should be fixed now. I set the main container to hide overflow and reduced the number of items displayed by one which seems to work. |
- Hide content after nth-child specified number - Add text-wrap-balance to stop orphan text wrapping onto new line
What
Amend 'Live Searches' dashboard:
Why
To be displayed at The White Chapel Building.