Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR to clean up the code #16

Open
wants to merge 50 commits into
base: feature/particlenet
Choose a base branch
from
Open

PR to clean up the code #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
00adab9
sort: met filters
anmalara Mar 17, 2023
b0cb614
gather object definitions
anmalara Mar 17, 2023
f4f0b37
gather selection definitions
anmalara Mar 17, 2023
92425e4
removed unused selections
anmalara Mar 17, 2023
6dc169e
remove ULEGACYV8 variable
anmalara Mar 17, 2023
3270f3e
remove ULEGACYV8 variable: big fix
anmalara Mar 17, 2023
ef4be25
sort region definitions + make list creation uniform
anmalara Mar 17, 2023
218ee2e
fix config file: remove unused variables + add new
anmalara Mar 17, 2023
4a70404
Update lumi json files
anmalara Mar 18, 2023
970502b
add printing
anmalara Mar 18, 2023
23cca4b
fix convention
anmalara Mar 21, 2023
a3bdfd0
update xsec
anmalara Mar 21, 2023
1cc1f3b
Add new plots for PN score
anmalara Mar 21, 2023
4ee2a6a
update name convention tree
anmalara Mar 21, 2023
779efb6
revert additional region stored
anmalara Mar 21, 2023
8955f61
compact ak4 definition
anmalara Mar 21, 2023
2ff8aef
removed unused variables
anmalara Mar 21, 2023
242e016
rename func
anmalara Mar 21, 2023
9bfa8f8
add doc strings
anmalara Mar 21, 2023
08950df
add default argument to run_quick
anmalara Mar 21, 2023
af8439b
merge
anmalara Mar 22, 2023
84c8310
update gitignore
anmalara Mar 22, 2023
18793db
update job splitting
anmalara Mar 23, 2023
f595436
uniform path creating and info storing
anmalara Mar 23, 2023
9e77f06
remove duplicate ylims
anmalara Mar 23, 2023
d9c26bd
generalise list of distributions
anmalara Mar 23, 2023
a1d5357
fix binning difference in qcd estimation
anmalara Mar 23, 2023
d048e33
remove duplicate
anmalara Mar 23, 2023
45d8b78
remove duplicate
anmalara Mar 23, 2023
e6063b5
update default binning
anmalara Mar 23, 2023
04be46d
uniform variables
anmalara Mar 23, 2023
5b9dc78
uniform variables 2
anmalara Mar 23, 2023
f958866
add control regions
anmalara Mar 23, 2023
fb52e43
Merge branch 'feature/particlenet' into particlenet
anmalara Mar 23, 2023
b6894d0
add plotting functions
anmalara Mar 23, 2023
c7d36bb
simplify plotting macros
anmalara Mar 23, 2023
b30d197
add disk request for crab
anmalara Mar 27, 2023
2fc7698
Merge branch 'particlenet' of github.com:anmalara/bucoffea into parti…
anmalara Mar 27, 2023
cfd4422
resolve conficts
anmalara Mar 27, 2023
d5426e1
bug fix
anmalara Mar 27, 2023
49ea8cd
add new shapes and regions
anmalara Mar 29, 2023
78f5f08
Merge branch 'feature/particlenet' of github.com:alpakpinar/bucoffea …
anmalara Mar 29, 2023
c11d462
more conservative splitting
anmalara Mar 30, 2023
18d3c5d
bug fix
anmalara Mar 30, 2023
4873ccb
bug fix
anmalara Mar 30, 2023
3ef1754
small changes
anmalara Apr 4, 2023
610a8d9
update submission
anmalara May 22, 2023
605eac1
update creation of root file for limits
anmalara May 22, 2023
4920c56
update scripts
anmalara May 22, 2023
f785ef3
Merge branch 'feature/particlenet' into particlenet
anmalara May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,12 @@ external
__pycache__
*.egg-info
*.coffea
*.pkl
*.root
*.pdf
*.png
*cutflow*.txt
monitor_log.txt
submission/
pkl/
pkl/
INFO.txt
2 changes: 2 additions & 0 deletions bucoffea/Submit.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# buexec -j1 vbfhinv submit --dataset '.*2018' --asynchronous --eventsperjob 5000000 --name "PFNANO_V9_17Feb23_PostNanoTools"
buexec -j1 vbfhinv submit --dataset '.*2018' --asynchronous --filesperjob 1 --name "PFNANO_V9_17Feb23_PostNanoTools"
8 changes: 4 additions & 4 deletions bucoffea/config/vbfhinv.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ default:
mass: 200
dphi: 1.5
deta: 1
highdphi: 2
highdeta: 3
cut_based:
mass: 1300
dphi: 1.5
Expand Down Expand Up @@ -135,7 +137,7 @@ default:
clean: false
dr: 0.4
mitigation:
hem: true
hem: True

sf:
qcd_ew_nlo_w: # QCD x EW k factor for QCD Z
Expand Down Expand Up @@ -221,8 +223,6 @@ default:
use_average: False

run:
sync: False
ulegacyv8: True
anmalara marked this conversation as resolved.
Show resolved Hide resolved
one_fifth_unblind: False
tight_mjj_cut: False
qcd_estimation: True
Expand All @@ -233,7 +233,7 @@ default:
regionregex: .*
apply_hf_cuts: True
hf_pt_thresh: 80
region_without_dijet_cuts: False
region_without_dijet_cuts: True
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to keep this on by default? I think it's fine, I was just thinking it might introduce additional runtime + memory constraints. Especially removing the dijet cuts can increase the number of events passing quite a bit - hence making ParticleNet input dict occupy larger amounts of memory.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep this on hold. I think that we should check the DNN distributions without these cuts.

apply_weights:
hfmask: False
endcap: False
Expand Down
1 change: 0 additions & 1 deletion bucoffea/data/json/Cert_271036-284044_13TeV_ReReco_07Aug2017_Collisions16_JSON.txt
View file
Open in desktop

This file was deleted.

Loading