This repository has been archived by the owner on Sep 25, 2023. It is now read-only.
Began integrating the portfolio page #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haydenshively
approved these changes
Jul 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title suggests, I began integrating the portfolio page. This includes fetching the data about a user's aloe positions as well as Uniswap v2 positions to display on their portfolio as well as the logic to display the empty states when the user doesn't have the respective position(s) (aloe/external). One thing that still needs to be done is the calculations for percentage change for both types of positions. Additionally, the logic needs a bit more error handling in order to make sure it is robust and doesn't crash ever (it shouldn't, but it is better to be safe). Lastly, as usual, below I attached some images of a few of the different states/cards (the ones with actual numbers are using addresses I found on etherscan):
