Make borrowed funds dst and repayment src configurable on Advanced page #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aloe-earn ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for aloe-prime canceled.
|
✅ Deploy Preview for aloe-blend-staging canceled.
|
IanWoodard
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard procedure is to immediately send borrowed funds to the user's wallet, and pull from the same in order to repay.
This change allows for an alternate path, where the user borrows but leaves funds in the NFT, or (similarly) use funds in the NFT to repay, instead of using funds from their wallet.
This can eliminate a few extra txns depending on the use-case, and will be particularly useful once we allow people to create Uniswap positions through the Advanced page