Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom tag hex and liquidation auction info to advanced page #822

Merged
merged 10 commits into from
Feb 26, 2024

Conversation

haydenshively
Copy link
Member

@haydenshively haydenshively commented Feb 24, 2024

image

Base automatically changed from hs-modalenum to master February 24, 2024 03:22
Copy link

netlify bot commented Feb 24, 2024

Deploy Preview for aloe-prime canceled.

Name Link
🔨 Latest commit 0142d78
🔍 Latest deploy log https://app.netlify.com/sites/aloe-prime/deploys/65dc034b759f0b000835a203

Copy link

netlify bot commented Feb 24, 2024

Deploy Preview for aloe-earn ready!

Name Link
🔨 Latest commit 0142d78
🔍 Latest deploy log https://app.netlify.com/sites/aloe-earn/deploys/65dc034b16669a0008895b61
😎 Deploy Preview https://deploy-preview-822--aloe-earn.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 24, 2024

Deploy Preview for aloe-blend-staging canceled.

Name Link
🔨 Latest commit 0142d78
🔍 Latest deploy log https://app.netlify.com/sites/aloe-blend-staging/deploys/65dc034beef7f500088a90db

Copy link
Collaborator

@IanWoodard IanWoodard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review: to be continued

Comment on lines +275 to +287
{mostRecentModifyHash && (
<HorizontalMetricCard label='Last Modified'>
<Text size='M'>
<a className='underline text-purple' rel='noreferrer' target='_blank' href={mostRecentModifyUrl}>
{mostRecentModifyTimeStr}
</a>{' '}
using {mostRecentManagerName ? 'the ' : 'an '}
<a className='underline text-purple' rel='noreferrer' target='_blank' href={mostRecentManagerUrl}>
{mostRecentManagerName ?? 'unknown manager'}
</a>
</Text>
</HorizontalMetricCard>
)}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different parts of this will be available at different times making it look a bit weird. It would be nice to add a placeholder of some kind.

earn/src/components/advanced/BorrowMetrics.tsx Outdated Show resolved Hide resolved
@haydenshively haydenshively merged commit 529ec04 into master Feb 26, 2024
18 checks passed
@haydenshively haydenshively deleted the hs-more-advanced-info branch February 26, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants