Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unify feature flag names and warning ids #46

Merged
merged 2 commits into from
Nov 25, 2024
Merged

fix: unify feature flag names and warning ids #46

merged 2 commits into from
Nov 25, 2024

Conversation

aripalo
Copy link
Contributor

@aripalo aripalo commented Nov 25, 2024 •
edited
Loading

To avoid confusion, unify feature flag names & warning IDs and align the naming convention to AWS CDK context keys:

V0 Tagging behavior

Feature Flag:

- @alma-cdk/project:compatibility:v0:tags
+ @alma-cdk/project:compatibilityV0Tags

Warning ID:

- @alma-cdk/project@v1:compatibility-v0-tags
+ @alma-cdk/project:compatibilityV0Tags

Legacy Tags

Warning ID:

- @alma-cdk/project@v1:legacy-tags
+ @alma-cdk/project:legacyTags

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
33.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@aripalo aripalo requested a review from a team November 25, 2024 15:38
@aripalo aripalo merged commit 585cbe5 into main Nov 25, 2024
9 checks passed
@aripalo aripalo deleted the fix/featureFlagAndWarningIds branch November 25, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aripalo