fix: compatiblity mode for v0 tagging behavior #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hyperinen
reviewed
Nov 20, 2024
jyrheikk
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous
v0incorrectly performed the "is value non-empty string" checks leading to a bug which causedOrganizationandContacttags to be left out.This bug was fixed in
betabranch, but it of course now causes CloudFormation diff.This PR adds
@alma-cdk/project:compatibility:v0:tagsfeature flag support that users can enable to avoid the diff.Long-term the current
beta-version tagging behavior (without the feature flag) will be default, so the feature flag will be removed in futurev2. But having the feature flag allows users to control when they want to include the new tags.Additionally this PR adds several tests, especially for the tagging behavior.
This PR also configures SonarCloud to not complain about use of code with
@deprecatedannotation in certain code paths, because we want to still use that code but by using@deprecatedto signal that those features will be removed in future major versions.