Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix attach (fixes #474) #549

Closed
wants to merge 20 commits into from
Closed

Bugfix attach (fixes #474) #549

wants to merge 20 commits into from

Conversation

Maksimymis
Copy link

Context

Cloning bugfix (attachments are cloned in the step and in the test)
(fixes #474)

Checklist

Denis Bautin and others added 20 commits January 8, 2021 19:25
Add to coftest.py reference on pytester plugin
51783a0
Move feature directory to allure-pytest-bdd\test\
43a6419
v1.0 Bug fix allure-framework#474
c8b6e0d 
Add file attachment_worker.py with AttachmentWorker class

Now PytestBDDListener use AttachmentWorker for deleting duplicate of attachments
Add files for test
65fdf5d
Small refactor
62420d3
Fix AttachmentWorker
fdd17fe
Small refactoring of AttachmentWorker
a597c8e
Add test for bug fix allure-framework#474
6ade3c3
Fix and refactor AttachmentWorker
fa83334
@example
AttachmentWorker refactor
004c7f7
Create directory attachments_tests and move bug474 tests to there
7d97237
Create directory tests and move outline_test.py, scenario_test.py to …
025b2cd 
…there
Create basis for PyFileBuilder, and acceptance.feature
88678d5
@example
Make a PyFileBuilder class and add a tests
ce6b446
@example
Add a valid reactions on unexpected cases and expand tests
a9a461c
Add common steps for testing
4ef079f 
Update acceptance.feature
Merge branch 'test-infrastructure' into master
bdac757
Merge branch 'master' into bugfix-attach
3fa32f7
Add steps for testing attachments
2cdf1aa
Change test on bug allure-framework#474
882ca4c
@CLAassistant
Copy link

CLAassistant commented Jan 23, 2021 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ Denis Bautin
❌ example

Denis Bautin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Maksimymis
Copy link
Author

Let us fix CLA signing and committers emails

@Maksimymis Maksimymis closed this Jan 24, 2021
@Duisus Duisus deleted the bugfix-attach branch January 24, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pytest-bdd: attachments are cloned in the step and in the test
3 participants
@Maksimymis @CLAassistant @example