fixed box-sizing default assumptions #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default box-sizing is content-box, not border-box. This causes a layout issue in IE 10 and probably others when no box-sizing is set and $.browser.boxModel is not available. Honestly, there is no reason to even make all those browser version checks anyway. Just fetch the boxSizing value and if its not available or not set, default to content-box. See: https://developer.mozilla.org/en-US/docs/Web/CSS/box-sizing
|
"Just fetch the boxSizing value and if its not available or not set, default to content-box." This is incorrect for IE6 & IE7 quirks-mode, which work like box-size=border-box, yet do not support box-size CSS. If all other browsers supported box-size, I would enable border-box in the hard-coded CSS to simplify calculations, but some do not support it so still need to test. I'll investigate the IE10+ issue you mention and fix as needed. I'll leave this PR open until resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default box-sizing is content-box, not border-box. This causes a layout issue in IE 10 and probably others when no box-sizing is set and $.browser.boxModel is not available. Honestly, there is no reason to even make all those browser version checks anyway. Just fetch the boxSizing value and if its not available or not set, default to content-box.
See: https://developer.mozilla.org/en-US/docs/Web/CSS/box-sizing