-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rpc-client): Introduce rpc-jsonrpsee Crate #37
Conversation
Note Depends on sync types from #35 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps we rename this to op-alloy-jsonrpsee ?
506aa0d
to
67f28a2
Compare
67f28a2
to
9edada8
Compare
Note Adds the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanna ask if it makes sense to implement a Provider
here over the Optimism
network. I was doing smth like this:
#[async_trait]
pub trait OpStackProvider<T: Transport + Clone = BoxTransport>: Provider<T, Optimism> {
async fn output_at_block(&self, block_number: u64) -> TransportResult<OutputAtBlock> {
let response = self
.client()
.request("optimism_outputAtBlock", (format!("0x{:x}", block_number),))
.await?;
Ok(response)
}
}
impl<T: Transport + Clone> OpStackProvider<T> for RootProvider<T, Optimism> {
}
yep this makes sense, mind opening an issue for this? |
Description
Introduces an
op-alloy-rpc-jsonrpsee
crate that can replace the non-type logicreth/optimism/rpc
. Type logic can go inop-alloy/rpc-types
.Closes #32