Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set op_alloy_rpc_types::Transaction as Optimism::TransactionResponse #33

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Set op_alloy_rpc_types::Transaction as Optimism::TransactionResponse #33

merged 1 commit into from
Aug 22, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Aug 21, 2024

Motivation

alloy_network::Network impl for Optimism needs to have unique types as associated types for integration in reth rpc

Solution

Replace alloy_rpc_types_eth::Transaction with op_alloy_rpc_types::Transaction for Optimism::TransactionResponse

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@emhane emhane requested a review from mattsse as a code owner August 21, 2024 15:19
@mattsse mattsse merged commit bb3b238 into main Aug 22, 2024
18 checks passed
@mattsse mattsse deleted the emhane/op-rpc-tx branch August 22, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse