Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-17: add url override to post block #42

Merged
merged 4 commits into from
Nov 10, 2023

Conversation

nikkifurls
Copy link
Contributor

Description

This PR adds a URL override feature to the Post block, allowing users to specify a custom URL with analytics tracking parameters, etc. The override is stored in attributes and used on the front end instead of the post URL.

Related to Issue #17: add url override to post block

Changes

  • Added a new attribute for storing the URL override
  • Modified the Post block to use the URL override if provided
  • Updated frontend rendering to use the URL override if available

Testing

  1. Create a new Post block and add a custom URL in the URL override field
  2. Verify that the custom URL is used on the frontend instead of the post URL
  3. Verify that the custom URL is properly saved in attributes
  4. Remove the custom URL and verify that the post URL is used on the frontend instead

@nikkifurls nikkifurls marked this pull request as ready for review November 10, 2023 20:30
Copy link
Collaborator

@mogmarsh mogmarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great - just update the version here and add an entry to the changelog. Once you do that, it will cut a release when you merge it. 👍

@nikkifurls nikkifurls merged commit c15c2e2 into develop Nov 10, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants