Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Single Send Enhancements #153

Merged
merged 13 commits into from
Jun 24, 2024
Merged

Feature: Single Send Enhancements #153

merged 13 commits into from
Jun 24, 2024

Conversation

efuller
Copy link
Contributor

@efuller efuller commented Jun 21, 2024 •
edited
Loading

Summary

  • For single-sends, recognize template updates
  • For now, remove the sent newsletters panel until we can make it more informational\
  • Add in an action that allows for preview markup/text to be added
  • Use post title rather than post id for single sent newsletters

Notes for reviewers

Ticket(s)

https://l.alley.dev/75b5288d9c

efuller added 10 commits June 20, 2024 15:54
@efuller
Append the post title instead of its id
bddf118
@efuller
Remove the Sent Newsletters panel from the single send sidebar.
8bc9dcd 
In the future, we intend to bring this back with a list of dates and times of when the newsletter was sent
@efuller
Change preview markup to work with SendGrid
bea44c0 
Add in a todo that will allow for different markup as each provider requirements vary
@efuller
Merge branch 'refs/heads/develop' into feature/single-send-enhancements
72584b3
@efuller
For single sends, update template if it has been updated
f51b50b
@efuller
Chores: phpcs
e31ed76
@efuller
Format preheader
a20a7b3
@efuller
Alphabetize
1c226a0
@efuller
Add in an action to allow for preview text to be used.
3b1ee66 
Since each email provider requires different markup, this action allows the implementer to be in charge
@efuller
Add a comment for useEffect responsible for updating template content
88c02aa
@efuller efuller marked this pull request as ready for review June 24, 2024 15:05
cahdeemer
cahdeemer approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@cahdeemer cahdeemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌻

single-nb_newsletter.php Show resolved Hide resolved
@efuller efuller merged commit bc645b2 into develop Jun 24, 2024
6 checks passed
@efuller efuller deleted the feature/single-send-enhancements branch June 24, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahdeemer cahdeemer cahdeemer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@efuller @cahdeemer