Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Pre Publish Checks #152

Merged
merged 26 commits into from
Jun 21, 2024
Merged

Feature: Pre Publish Checks #152

merged 26 commits into from
Jun 21, 2024

Conversation

efuller
Copy link
Contributor

@efuller efuller commented Jun 18, 2024 •
edited
Loading

Summary

  • Adds in a pre-publish check that requires a newsletter to have a title
  • Removes the EmailSettings block from the NB Template
  • Changes the contentHandler in EmailSettings to account for the EmailSettings block not being in the NB Template
  • Updates Mantle Testkit and fixes unit tests

Notes for reviewers

Ticket(s)

https://l.alley.dev/8a99e14972

efuller added 25 commits June 13, 2024 15:59
@efuller
Scaffold pre publish panel plugin
4023eee
@efuller
Add in a pre-publish check on newsletters for titles
0e658dd
@efuller
Rename pre-publish panel
0f1f240
@efuller
Check for empty title
d0c9420
@efuller
Remove email settings from nb_template post type
e3abd0d
@efuller
Comment cleanup
d474c77
@efuller
Adjust the content handler
b70d3c6 
Allow it to account for the email settings block being removed from the NB templated.
@efuller
Npm audit fix
6f0e421
@efuller
Bump PHP to 8.1
ab80a8c
@efuller
Remove 8.0 from PHP matrix
933a490
@efuller
Adjust test file names to PSR-4
88c9d7d
@efuller
Try updating phpunit.xml
bc8767a
@efuller
Remove printerClass from phpunit.xml
21bcd22
@efuller
Change example test name
f76c050
@efuller
Try removing schema
7b56983
@efuller
Revert test files
4566a19
@efuller
Continue to use PHPUnit 9
4192272
@efuller
Merge branch 'refs/heads/develop' into feature/pre-publish-checks
ad85693 
# Conflicts:
#	composer.json
@efuller
Add printerClass back in
6a703f7
@efuller
Downgrade testkit to v1.0.7 as there is a bug in v1.1
753b409
@efuller
Configure tests
4f06836
@efuller
Let's try falling back to PHPUnit v9
7d61a4b
@efuller
Upgrade testkit to 1.1.2
af65ce9
@efuller
Get tests working on PHPUnit 10
6ae9b90
@efuller
A bit of code cleanup
21663a6
@efuller efuller marked this pull request as ready for review June 20, 2024 19:04
cahdeemer
cahdeemer approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@cahdeemer cahdeemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌻

@efuller efuller merged commit 0df8922 into develop Jun 21, 2024
6 checks passed
@efuller efuller deleted the feature/pre-publish-checks branch June 21, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahdeemer cahdeemer cahdeemer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@efuller @cahdeemer