add support for post_types to rest api #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlh01
reviewed
Sep 15, 2023
Comment on lines
+28
to
+41
| /** | ||
| * Add post_type to rest post query if the type param is set. | ||
| * | ||
| * @param array<array<int, string>|string> $query_args The existing query args. | ||
| * @param \WP_REST_Request $request The REST request. | ||
| * @return array<array<int, string>|string> | ||
| */ | ||
| public function add_type_param( $query_args, $request ): array { // @phpstan-ignore-line | ||
| if ( ! empty( $request->get_param( 'type' ) ) && is_string( $request->get_param( 'type' ) ) ) { | ||
| $types = explode( ',', $request->get_param( 'type' ) ); | ||
| $types = array_filter( $types, 'post_type_exists' ); | ||
| $query_args['post_type'] = $types; | ||
| } | ||
| return $query_args; |
There was a problem hiding this comment.
I get where this is coming from, but I'm concerned that it's not really the correct use of the REST API. It will cause the API to try to apply the schema for the post post type to posts from any post type, which might have unpredictable results. The search endpoint is more annoying to use but might be more correct for this case.
kaitlinbolling
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for post_types to rest api and allow
wp_curate_deduplicationon all post types.handles #54 and sort of #56 (could be handled better)