Merge pull request #64 from alleyinteractive/bug/dataset-compatibility

Add getAttribute as a fallback for dataset.
alleyinteractive · Dec 16, 2016 · 844c20f · 844c20f
2 parents 25c8ebc + 05cec31
commit 844c20f
Show file tree

Hide file tree

Showing 6 changed files with 97 additions and 32 deletions.
diff --git a/dist/cli/require-templates.js b/dist/cli/require-templates.js
diff --git a/dist/cli/require-templates.js.map b/dist/cli/require-templates.js.map
diff --git a/dist/web/huron.js b/dist/web/huron.js
diff --git a/dist/web/huron.js.map b/dist/web/huron.js.map
diff --git a/src/cli/require-templates.js b/src/cli/require-templates.js
@@ -11,6 +11,9 @@ const huronScript = fs.readFileSync(
 
 /**
  * Write code for requiring all generated huron assets
+ * Note: prepended and appended code in this file should roughly follow es5 syntax for now,
+ *  as it will not pass through the Huron internal babel build nor can we assume the user is
+ *  working with babel.
  *
  * @function requireTemplates
  * @param {object} store - memory store
@@ -25,9 +28,9 @@ export const requireTemplates = function requireTemplates(store) {
 
   // Initialize templates, js, css and HMR acceptance logic
   const prepend = `
-let store = require('./huron-store.js');
-const assets = require.context(${requirePath}, true, ${requireRegex});
-const modules = {};
+var store = require('./huron-store.js');
+var assets = require.context(${requirePath}, true, ${requireRegex});
+var modules = {};
 
 assets.keys().forEach(function(key) {
   modules[key] = assets(key);
@@ -37,12 +40,12 @@ if (module.hot) {
   module.hot.accept(
     assets.id,
     () => {
-      const newAssets = require.context(
+      var newAssets = require.context(
         ${requirePath},
         true,
         ${requireRegex}
       );
-      const newModules = newAssets.keys()
+      var newModules = newAssets.keys()
         .map((key) => {
           return [key, newAssets(key)];
         })