Handling archiveless posts in Elasticsearch plugins
#64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toggling the "Hide from Archives" button obliterates a post from Elasticsearch. Not only hidden but literally gone.
This pull request changes this behavior for the VIP Search, ElasticPress, and SearchPress plugins. Ensuring the archived posts are kept indexed in Elasticsearch.
Similar support was added to the Elasticsearch Extensions plugin: alleyinteractive/elasticsearch-extensions#59
But if a site is not using it, this will ensure the archived posts are kept indexed.
And since the Elasticsearch Extensions hook is run at a later priority, there is no possibility of the status being added here if the plugin restricts it. :)
fixes #62