Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.12 via newer scipy and nmslib-metabrainz #523

Merged
merged 13 commits into from
Sep 15, 2024

Conversation

jason-nance
Copy link
Contributor

@jason-nance jason-nance commented Aug 29, 2024

Addresses #519.

  • Allows for installing scipy>=1.11 when Python version >= 3.11, but this prevents testing and running the code that generates the linkers.
  • Depends on nmslib-metabrainz rather than nmslib for newer Python versions, since the latter hasn't yet incorporated support for Python 3.11+.
  • Upgrades the scispacy model in the Dockerfile to 0.5.4, so the steps in the Dockerfile will run correctly on Python 3.12.

I don't have any strong opinions on the small decisions made here (e.g. should we install latest scipy by default when Python<3.11?), just trying to get something that will install on Python 3.12. Happy to revise as desired.

Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this!

scispacy/candidate_generation.py Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
requirements.in Outdated Show resolved Hide resolved
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dakinggg dakinggg merged commit e93baa4 into allenai:main Sep 15, 2024
3 checks passed
@jason-nance
Copy link
Contributor Author

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants