fix: incorrectly formatted URLs #364
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It has been almost a year since I filed this pull request, yet not a single word from maintainers. Thousands of projects still rely on this tool, yet doing the bare minimum of keeping the project alive is too hard? Come on... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Fixed a bug where URLs may be malformed and an additonal bug which improved CLS on generated files
Why: Newer GitHub URLs may come with a ?v=4 query already, making these URLs malformed causing errors and incorrect sizings. This will size images properly, saving on data and web load times. There is also a fix to reduce the CLS by defining the width and height of the image.
How: URLs are being formatted with the URL class to ensure URL safety.
Checklist: