resource/alicloud_ess_scheduled_task: update launch_expiration_time range. #8028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuliu-zln
force-pushed
the
feat/task
branch
3 times, most recently
from
4a8b196 to
b9a7a3f
Compare
| @@ -47,7 +47,7 @@ func resourceAlicloudEssScheduledTask() *schema.Resource { | |||
| Type: schema.TypeInt, | |||
| Default: 600, | |||
| Optional: true, | |||
| ValidateFunc: validation.IntBetween(0, 21600), | |||
| ValidateFunc: validation.IntBetween(0, 1800), | |||
There was a problem hiding this comment.
这个缩减了是非兼容的，会导致客户模板报错。另外直接使用common下的IntBetween即可
There was a problem hiding this comment.
1.API 后端的约束目前就是0-1800 之前的应该是之前接入有问题
- 使用common下的IntBetween即可 done
fuliu-zln
force-pushed
the
feat/task
branch
2 times, most recently
from
a560651 to
40454f5
Compare
| @@ -133,7 +133,7 @@ The following arguments are supported: | |||
| The time must be in UTC. You cannot enter a time point later than 90 days from the date of scheduled task creation. | |||
| If the `recurrence_type` parameter is specified, the task is executed repeatedly at the time specified by LaunchTime. | |||
| Otherwise, the task is only executed once at the date and time specified by LaunchTime. | |||
| * `launch_expiration_time` - (Optional) The time period during which a failed scheduled task is retried. Unit: seconds. Valid values: 0 to 21600. Default value: 600 | |||
| * `launch_expiration_time` - (Optional) The time period during which a failed scheduled task is retried. Unit: seconds. Valid values: 0 to 1800. Default value: 600 | |||
There was a problem hiding this comment.
这个变更加个说明吧，从哪个版本起取值范围缩减了
MrWolong
reviewed
Dec 26, 2024
| @@ -133,7 +133,7 @@ The following arguments are supported: | |||
| The time must be in UTC. You cannot enter a time point later than 90 days from the date of scheduled task creation. | |||
| If the `recurrence_type` parameter is specified, the task is executed repeatedly at the time specified by LaunchTime. | |||
| Otherwise, the task is only executed once at the date and time specified by LaunchTime. | |||
| * `launch_expiration_time` - (Optional) The time period during which a failed scheduled task is retried. Unit: seconds. Valid values: 0 to 21600. Default value: 600 | |||
| * `launch_expiration_time` - (Optional) The time period during which a failed scheduled task is retried. Unit: seconds. Valid values: 0 to 1800, Available in 1.239.0. Default value: 600 | |||
There was a problem hiding this comment.
Available since v1.240.0
fuliu-zln
force-pushed
the
feat/task
branch
2 times, most recently
from
24811a6 to
46735ee
Compare
fuliu-zln
force-pushed
the
feat/task
branch
2 times, most recently
from
c2cec51 to
1ba7452
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.