feat: add imds and external uri in default chain && resolve credentia… #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
peze
reviewed
Nov 6, 2024
yndu13
reviewed
Nov 6, 2024
src/providers/ram_role_arn.ts
Outdated
| } | ||
|
|
||
| if (!this.enableVpc) { | ||
| this.enableVpc = process.env.ALIBABA_CLOUD_VPC_ENDPOINT_ENABLED === 'true' || false; |
There was a problem hiding this comment.
this.enableVpc == false也判断上了
yndu13
reviewed
Nov 6, 2024
yndu13
reviewed
Nov 6, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #124 +/- ##
==========================================
+ Coverage 97.91% 98.00% +0.08%
==========================================
Files 35 36 +1
Lines 1103 1201 +98
Branches 181 206 +25
==========================================
+ Hits 1080 1177 +97
Misses 12 12
- Partials 11 12 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
yndu13
approved these changes
Nov 7, 2024
yndu13
force-pushed
the
master
branch
4 times, most recently
from
506306e to
c25e9e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ls timeout