🎁 Dropdown #61
Merged
🎁 Dropdown #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly type updates needed due to some react-aria package updates after installing new packages for dropdown implementation.
alirezamirian
force-pushed
the
2024-07
branch
3 times, most recently
from
4735f2c to
7fcac2f
Compare
The issue with button not receiving PressResponder props was due to .mjs entry being loaded through @react-aria/selection and .main.js entry being loaded when imported from source, because imports are transpiled to require and `require` entry of the package.json exports being picked.
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
alirezamirian
force-pushed
the
2024-07
branch
3 times, most recently
from
6fe93bb to
3386177
Compare
…pen method example-app is also refactored to fix the regression in delete file(s) action. The issue started to happen after upgrading to the latest version of @react-aria/focus, but it's because the deletion happens in the confirmation dialog, and before its closed. So the node to restore the focus to is removed when the focus restoration logic runs. Note: upgrade of @react-aria/overlays didn't have anything to do with the fix, but was kept anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://plugins.jetbrains.com/docs/intellij/drop-down.html