Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎁mnemonic, 🎁ButtonGroup, e2e tests #59

Merged
merged 7 commits into from
May 30, 2024
Merged

🎁mnemonic, 🎁ButtonGroup, e2e tests #59

merged 7 commits into from
May 30, 2024

Conversation

alirezamirian
Copy link
Owner

Library:

  • 🎁mnemonic
  • 🎁ButtonGroup

Website:

  • Improved linking

Example app:

  • e2e tests
  • zero state for editor, commits and git tool windows
  • minor bugfixes

Auto linking is done in a few places:
- In MDX files when `ComponentName` is used as markdown inline code.
  That's done by adding inlineCode entry to the swizzled MDXComponents.
- In jsdoc descriptions that are rendered via Markdown component, when `ComponentName` is used as markdown inline code.
  That's done by swizzling Code component. Note that Code component is not used for inline code snippets in mdx files.
- In jsdoc descriptions that are rendered via Markdown component, when {@link ComponentName} is used. That's done by a string find replace in jsdoc content.
in button and checkbox and as a standalone component.

Also included:
- fix(modal): apply aria-hidden on the content outside top-most modal window
@alirezamirian alirezamirian force-pushed the 2024-05 branch 10 times, most recently from 0c0117c to f71e19c Compare May 28, 2024 20:33
Copy link

cypress bot commented May 28, 2024

Passing run #217 ↗︎

0 293 7 0 Flakiness 0

Details:

Merge 213640c into cf7542c...
Project: JUI Commit: 1250f274f5 ℹ️
Status: Passed Duration: 02:36 💡
Started: May 29, 2024 8:31 PM Ended: May 29, 2024 8:34 PM

Review all test suite changes for PR #59 ↗︎

e2e tests are for example-app, but kept in the same cypress setup for simpler reuse of shared cypress configuration needed for both cases.
@alirezamirian alirezamirian merged commit d8b4066 into master May 30, 2024
20 checks passed
@alirezamirian alirezamirian deleted the 2024-05 branch May 30, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant