Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024 02 #55

Merged
merged 34 commits into from
Mar 17, 2024
Merged

2024 02 #55

merged 34 commits into from
Mar 17, 2024

Conversation

alirezamirian
Copy link
Owner

No description provided.

also added the option to decide based on the blur event
Other changes:
- More options on Tooltip trigger to control positioning
- Components for various flavors of tooltip now offer extra props from tooltip
Using selector as the default value of vcsRootsState was causing two issues:
- page blinks when refreshing any selector that used vcsRootsState
- An exception thrown from RecoilSync, when refreshing `allCommitsState`
…ta is being loaded

also: fix a console warning. Rendering PopupTrigger with null children was making react-aria unhappy
For lists with large number of items, virtualization makes a huge impact on performance.
remove unnecessary minWidth style which doesn't let list shrink to the available space.
…lementation

to support reading commits from multiple repos and branches, and to include ref information for each commit
…in git toolwindow

Extracting reusable abstractions related to changes and changes tree, and de-coupling them from changes view in commit window.

Also added type checking to example-app
Specifically for rename detection logic.
@alirezamirian alirezamirian force-pushed the 2024-02 branch 3 times, most recently from 4a3fe6b to c0bc0b7 Compare March 16, 2024 15:21
@alirezamirian alirezamirian force-pushed the 2024-02 branch 2 times, most recently from 52ab7c8 to 708453a Compare March 16, 2024 18:50
Focusing input with .focus() may or may not work depending on the order of test. Probably some issue in the underlying react-aria libs, but worked around it as focusing by tab (which matters most) seems to work reliably.
Copy link

cypress bot commented Mar 16, 2024

Passing run #195 ↗︎

0 257 6 0 Flakiness 0

Details:

Merge 416bc71 into 1f5e0b9...
Project: JUI Commit: 09cadd9d0e ℹ️
Status: Passed Duration: 02:33 💡
Started: Mar 17, 2024 8:30 PM Ended: Mar 17, 2024 8:33 PM

Review all test suite changes for PR #55 ↗︎

@alirezamirian alirezamirian force-pushed the 2024-02 branch 3 times, most recently from 923eb6c to 5ed96be Compare March 17, 2024 18:48
@alirezamirian alirezamirian merged commit 2d83f23 into master Mar 17, 2024
15 checks passed
@alirezamirian alirezamirian deleted the 2024-02 branch March 17, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant