2023-12 #52
Merged
2023-12 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alirezamirian
force-pushed
the
2023-12
branch
from
23b885f to
9e9e0da
Compare
react-aria link is too restrictive, without good reason, at least based on what link component means in Intellij Platform
There is most probably a need for a more generic support for such feature: disabling focus from getting lost, if a non-focusable element is being clicked. Some cases are covered by FocusScope usages, some other cases are covered by `preventFocusOnPress` option in some interactive components, and here it's handled like this.
Sometimes the blur event was not happening, so two calls to `useActivePathsProvider` from two different places would fight over the recoil state as they had different values for activePaths. One reproduction scenario was resizing commit window, while it's focused. The focus would immediately go to the editor (which itself is a bug, but unrelated), but the blur event was not triggered for some reason. With this change, for each focused based state controller hook we keep track of the currently focused element, and update the value only the latest focused element is the same as current element. i.e. only one usage of each hook controls the state at a given time.
Although the assumption about ref value not being null is correct in normal circumstances, it error cases, it can happen that the value of the ref is null, and not handling null here, creates confusing unrelated error on top of the root cause.
Tool window header (Tabs in most cases) should not be pushed, but should overflow out, when resizing to very small sizes.
alirezamirian
force-pushed
the
2023-12
branch
2 times, most recently
from
28cde34 to
8bb826c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Top highlights: