Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add defaultVariables options to initialize properties #187

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

binyar
Copy link

@binyar binyar commented Jun 27, 2022

In my project, there will be a lot of the same local app data variabls:
e.g

{
"a": "Hello,{appName}",
"b": "Hi,{appName}",
"c": "Good well,{appName}",
...
}

JS code (Before)

// file1
Intl.get('a',{appName:'wahaha'});
// file2
Intl.get('b',{appName:'wahaha'});
// file3
Intl.get('c',{appName:'wahaha'});

JS code(After)

intl.init({
 ...
defaultVariables:{
 appName:"wahaha"
}
})
// file1
Intl.get('a');
// file2
Intl.get('b');
// file3
Intl.get('c');

I want to use a default variables to avoid generating a lot of duplicate code

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


fanmd seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cwtuan
Copy link
Collaborator

cwtuan commented Jul 4, 2022

please add some test cases.

@binyar
Copy link
Author

binyar commented Aug 16, 2022

please add some test cases.

hi bro, maybe you can have a look at of this,I will use the feature plz.

@cwtuan
Copy link
Collaborator

cwtuan commented Aug 19, 2022

Please don't include personal or compony information in the test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants