[kv] Partition table support PrefixLookup #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swuferhong
force-pushed
the
prefix-support-partition-yable
branch
from
7e9df81 to
b286d5a
Compare
2 tasks
|
@loserwang1024 @luoyuxia @loserwang1024 pr ready: Partition table support PrefixLookup. |
wuchong
requested changes
Jan 17, 2025
fluss-common/src/main/java/com/alibaba/fluss/metadata/TableDescriptor.java
Outdated
Show resolved
Hide resolved
fluss-client/src/test/java/com/alibaba/fluss/client/admin/ClientToServerITCaseBase.java
Show resolved
Hide resolved
fluss-client/src/main/java/com/alibaba/fluss/client/table/FlussTable.java
Outdated
Show resolved
Hide resolved
|
Besides, add connector IT case in |
swuferhong
force-pushed
the
prefix-support-partition-yable
branch
from
b286d5a to
be9ec89
Compare
Added. |
|
@wuchong comments addressed. PTAL |
swuferhong
force-pushed
the
prefix-support-partition-yable
branch
2 times, most recently
from
64202e7 to
86e1285
Compare
|
@wuchong comments addressed. I also refactor the lookup interface for making the logic of creating encoder for primary key, bucket key, and partition key more clearer. |
wuchong
reviewed
Jan 25, 2025
fluss-client/src/main/java/com/alibaba/fluss/client/utils/ClientUtils.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/alibaba/fluss/connector/flink/source/lookup/FlinkAsyncLookupFunction.java
Outdated
Show resolved
Hide resolved
fluss-client/src/main/java/com/alibaba/fluss/client/lookup/FlussLookuper.java
Outdated
Show resolved
Hide resolved
fluss-client/src/main/java/com/alibaba/fluss/client/table/FlussTable.java
Outdated
Show resolved
Hide resolved
|
@swuferhong , I appended a commit to fix the comments and improved the code. Please take a look. |
wuchong
added a commit
to swuferhong/fluss
that referenced
this pull request
Jan 25, 2025
…libaba#317) This also makes Lookuper and PrefixLookuper to initialize and validate for themselves. This makes logic much clean, and avoid mis-reuse for some variables (e.g., lakeTableBucketAssigner). This also introduced a UnifiedLookuper in Flink connector to unify the different API of Lookuper and PrefixLookup. This makes the logic of AsyncLookupFunction and LookupFunction simpler.
wuchong
force-pushed
the
prefix-support-partition-yable
branch
from
86e1285 to
f3a2f91
Compare
wuchong
approved these changes
Jan 25, 2025
…libaba#317) This also makes Lookuper and PrefixLookuper to initialize and validate for themselves. This makes logic much clean, and avoid mis-reuse for some variables (e.g., lakeTableBucketAssigner). This also introduced a UnifiedLookuper in Flink connector to unify the different API of Lookuper and PrefixLookup. This makes the logic of AsyncLookupFunction and LookupFunction simpler.
wuchong
force-pushed
the
prefix-support-partition-yable
branch
from
f3a2f91 to
6298eb6
Compare
|
LGTM +1, I think it can be merged. @wuchong |
wuchong
pushed a commit
that referenced
this pull request
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: #266
This pr is aims to make partition table support
PrefixLookup.Tests
API and Format
Documentation