-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hotfix] Report empty string as value for partition label for non-partitioned table #316
Merged
luoyuxia
merged 6 commits into
alibaba:main
from
michaelkoepf:hotfix/metric-labels-for-non-partitioned-tables
Jan 9, 2025
Merged
[hotfix] Report empty string as value for partition label for non-partitioned table #316
luoyuxia
merged 6 commits into
alibaba:main
from
michaelkoepf:hotfix/metric-labels-for-non-partitioned-tables
Jan 9, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Report empty string as value for partition label for non-partitioned table Issue alibaba#302
Added test cases for Prometheus metric exporter Issue alibaba#302
Fixed spotless errors Issue alibaba#302
Adapted JMX reporter test cases Issue alibaba#302
michaelkoepf
changed the title
[WIP][hotfix] Metric labels for non partitioned tables
[hotfix] Metric labels for non partitioned tables
Jan 8, 2025
2 tasks
- Fix spotless errors - Change debug message
michaelkoepf
force-pushed
the
hotfix/metric-labels-for-non-partitioned-tables
branch
from
January 8, 2025 20:37
2d1f5b1
to
bb9806f
Compare
michaelkoepf
changed the title
[hotfix] Metric labels for non partitioned tables
[hotfix] Metric labels for non-partitioned tables
Jan 8, 2025
luoyuxia
reviewed
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaelkoepf Thanks for the pr. Just one comment. Otherwise, LGTM!
fluss-server/src/main/java/com/alibaba/fluss/server/metrics/group/PhysicalTableMetricGroup.java
Outdated
Show resolved
Hide resolved
Adaptions according to PR review
luoyuxia
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaelkoepf Thanks.. LGTM! Will merge later
luoyuxia
changed the title
[hotfix] Metric labels for non-partitioned tables
[hotfix] report empty string as value for partition label for non-partitioned table
Jan 9, 2025
luoyuxia
changed the title
[hotfix] report empty string as value for partition label for non-partitioned table
[hotfix] Report empty string as value for partition label for non-partitioned table
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #302
Tests
See changes in
com.alibaba.fluss.metrics.prometheus.PrometheusReporterDifferentLabelValueTest
com.alibaba.fluss.metrics.jmx.JMXReporterTest
Additional manually verification by creating the following 2 tables
in the Flink SQL client and check if all metrics are reported in Prometheus and JMX.
Prometheus
JMX (non-partitioned tables have a single entry with an empty string as key)
API and Format
n/a
Documentation
n/a