[Feature] Enhance CommonTestUtils#retry log for easier troubleshooting #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyubin117
force-pushed
the
retry-log
branch
2 times, most recently
from
e6b4c92 to
aed2ebb
Compare
wuchong
reviewed
Dec 23, 2024
| LOG.info( | ||
| "Attempt failed, sleeping for {} ms, and then retrying. caused by: {}\n", | ||
| waitMs, | ||
| t.getMessage()); |
There was a problem hiding this comment.
Thanks for the contribution @liyubin117 . However, the intermediate error message should be the same with the final error message? Does it provide any additional information?
There was a problem hiding this comment.
thanks for your reminds, I have added aggregated errors, we can see all occured errors instead of the latest error.
liyubin117
force-pushed
the
retry-log
branch
3 times, most recently
from
99f1a4b to
02e1403
Compare
liyubin117
force-pushed
the
retry-log
branch
from
02e1403 to
e59f92f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #253
Enhance CommonTestUtils#retry log for easier troubleshooting
Tests
API and Format
Documentation