[conf][server] Make the size of the threads pool in tablet server scheduler configurable. #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwj6591812
reviewed
Dec 9, 2024
| @@ -210,6 +210,13 @@ public class ConfigOptions { | |||
| "This configuration controls the directory where fluss will store its data. " | |||
| + "The default value is /tmp/fluss-data"); | |||
|
|
|||
| public static final ConfigOption<Integer> SCHEDULER_THREADS = | |||
| key("scheduler.threads") | |||
There was a problem hiding this comment.
tablet-server.scheduler.threads?
TABLET_SERVER_SCHEDULER_THREADS?
wuchong
reviewed
Dec 17, 2024
There was a problem hiding this comment.
@RocMarshal Thanks for the contribution. I left some comments.
| @@ -202,6 +202,13 @@ public class ConfigOptions { | |||
| .noDefaultValue() | |||
| .withDescription("The id for the tablet server."); | |||
|
|
|||
| public static final ConfigOption<Integer> TABLET_SERVER_SCHEDULER_THREADS = | |||
| key("tablet-server.scheduler.threads") | |||
There was a problem hiding this comment.
server.background.threads for simplification
| .intType() | ||
| .defaultValue(10) | ||
| .withDescription( | ||
| "This configuration item to set the core threads for the fluss scheduler in tablet servers."); |
There was a problem hiding this comment.
"The number of threads to use for various background processing tasks."
|
Besides, please rebase branch to latest |
|
Thanks all~ |
polyzos
pushed a commit
to polyzos/fluss
that referenced
this pull request
Dec 18, 2024
… of server scheduler (alibaba#126) This closes alibaba#125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Make the size of the threads pool in tablet server scheduler configurable.
Linked issue: close #125
Tests
N.A
API and Format
N.A
Documentation
N.A