-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[breakchange] refact lazy local variable #403
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poor-circle
force-pushed
the
refact_lazy_local
branch
from
November 21, 2024 09:27
c506b98
to
2d55780
Compare
ChuanqiXu9
reviewed
Nov 21, 2024
ChuanqiXu9
reviewed
Nov 21, 2024
ChuanqiXu9
reviewed
Nov 21, 2024
poor-circle
force-pushed
the
refact_lazy_local
branch
2 times, most recently
from
November 21, 2024 12:23
246ff34
to
4289594
Compare
poor-circle
force-pushed
the
refact_lazy_local
branch
from
November 21, 2024 12:23
4289594
to
aa8ae38
Compare
ChuanqiXu9
reviewed
Nov 22, 2024
ChuanqiXu9
reviewed
Nov 22, 2024
ChuanqiXu9
reviewed
Nov 26, 2024
ChuanqiXu9
reviewed
Nov 26, 2024
ChuanqiXu9
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Now, the lazy local is a void*, which is dangerous, and user need manage life-time manually.
What is changing
Refact lazy local. Now we allow user add local variable derived from
LazyLocalBaseImpl
. we aslo supportSimpleLazyLocal
for simple local variable case.Example
The type check is very fast (only need compare a pointer). Dont need RTTI.