Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get instances error. #294

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: get instances error. #294

wants to merge 1 commit into from

Conversation

lework
Copy link

@lework lework commented May 24, 2021

No description provided.

@CLAassistant
Copy link

CLAassistant commented May 24, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lework
Copy link
Author

lework commented May 24, 2021

这里已经获取 region 全部的实例了。

https://github.com/alibaba/footmark/blob/0421bfb30d94f252a56c5d80a8696d37331b60b9/footmark/ecs/connection.py#L300-L320

原代码在 region 实例数 == page_size 的时候会出现死循环。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lework @CLAassistant