Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore/testing-cleanup #9

Closed
wants to merge 2 commits into from
Closed

chore/testing-cleanup #9

wants to merge 2 commits into from

Conversation

kylebeee
Copy link
Collaborator

@kylebeee kylebeee commented Apr 15, 2024 •
edited
Loading

ℹ Overview

  • cleans up a fixture
  • adds specific http exception types for errors
  • updates unit tests to expect specific http exceptions

✅ Acceptance:

  • Conventional Commits

@ori-shem-tov ori-shem-tov requested a review from PhearZero April 16, 2024 09:48
@kylebeee @ori-shem-tov
Update services/liquid-auth-api-js/tests/constants.ts
a530ed0 
replaced 1234 challenge with random string

Co-authored-by: ori-shem-tov <[email protected]>
@kylebeee kylebeee changed the title cleaned up unit tests / exceptions in endpoint & made fixture more in… chore/testing-cleanup Apr 16, 2024
PhearZero
PhearZero approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@PhearZero PhearZero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhearZero PhearZero mentioned this pull request Apr 24, 2024
Merged
2 tasks
@PhearZero
Copy link
Member

Included in #13

@PhearZero PhearZero closed this Apr 24, 2024
@PhearZero PhearZero deleted the chore/testing-cleanup branch May 4, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ori-shem-tov ori-shem-tov ori-shem-tov left review comments

@PhearZero PhearZero PhearZero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kylebeee @PhearZero @ori-shem-tov