Merge pull request #23 from algorandfoundation/chore/remove-hardcoded…

…-demo-credentials chore/remove-hardcoded-demo-credentials
algorandfoundation · Jun 3, 2024 · 1008cf1 · 1008cf1
2 parents abca8f2 + 12101a0
commit 1008cf1
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/.env.docker b/.env.docker
@@ -22,4 +22,4 @@ HOSTNAME=catfish-pro-wolf.ngrok-free.app
 ORIGIN=https://catfish-pro-wolf.ngrok-free.app
 
 ANDROID_SHA256HASH=47:CC:4E:EE:B9:50:59:A5:8B:E0:19:45:CA:0A:6D:59:16:F9:A9:C2:96:75:F8:F3:64:86:92:46:2B:7D:5D:5C
-ANDROID_PACKAGENAME=foundation.algorand.demo
+ANDROID_PACKAGENAME=foundation.algorand.demo
diff --git a/.gitignore b/.gitignore
@@ -101,6 +101,7 @@ web_modules/
 .env.test.local
 .env.production.local
 .env.local
+!sites/dapp-ui/.env
 
 # parcel-bundler cache (https://parceljs.org/)
 .cache

diff --git a/sites/dapp-ui/.env b/sites/dapp-ui/.env
@@ -0,0 +1,2 @@
+VITE_TURN_USERNAME="fc7708976bf5d60be20c5a1d"
+VITE_TURN_CREDENTIAL="sVpEREQGGhXOw4gX"
diff --git a/sites/dapp-ui/src/components/ConnectModal.tsx b/sites/dapp-ui/src/components/ConnectModal.tsx
@@ -65,8 +65,10 @@ export function ConnectModal({
               "turn:global.relay.metered.ca:443",
               "turns:global.relay.metered.ca:443?transport=tcp"
             ],
-            username: "fc7708976bf5d60be20c5a1d",
-            credential: "sVpEREQGGhXOw4gX",
+            // default username and credential when the turn server doesn't
+            // use auth, the client still requires a value
+            username: import.meta.env.VITE_TURN_USERNAME || 'username',
+            credential: import.meta.env.VITE_TURN_CREDENTIAL || 'credential',
           },
         ],
         iceCandidatePoolSize: 10,
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		VITE_TURN_USERNAME="fc7708976bf5d60be20c5a1d"
		VITE_TURN_CREDENTIAL="sVpEREQGGhXOw4gX"