Upgraded to eslint v9 with flat file config #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I upgraded the eslint to v9 flat file config. I had to remove the makerx/eslint-config because it's not in the flat file format. I took the rules and plugins and put them in this new config. There were several unused eslint rules after I made the change. These are most of the unused rules that I had to remove. We are using the recommended tseslint rules and these are found in either the "strict" or "stylistic" rulesets. There were several no-non-null-assertions that I removed. I think it's better to handle those non-null values but I don't know the code enough to make that call. They could be ok.
Unused eslint-disable directive (no problems were reported from '@typescript-eslint/no-empty-function')
Unused eslint-disable directive (no problems were reported from '@typescript-eslint/no-explicit-any')
Unused eslint-disable directive (no problems were reported from '@typescript-eslint/no-non-null-assertion')
Unused eslint-disable directive (no problems were reported from 'no-console')
Unused eslint-disable directive (no problems were reported from 'no-constant-condition')
Unused eslint-disable directive (no problems were reported from 'no-param-reassign')