Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: prereqs for puya debugging support #315

Merged
merged 15 commits into from
Sep 27, 2024
Merged

refactor: prereqs for puya debugging support #315

merged 15 commits into from
Sep 27, 2024

Conversation

aorumbayev
Copy link
Contributor

@aorumbayev aorumbayev commented Sep 20, 2024 •
edited
Loading

Proposed Changes

  • Deprecating persistSourceMaps
  • Additionally addresses issues with node specific debug utils, making utils-ts isomorphic and splitting node specific debug utils into a separate package algokit-utils-debug

Further Notes

Just a draft - can be used with per-branch installed as part of related work streams on puya debugging support

@aorumbayev aorumbayev mentioned this pull request Sep 24, 2024
Merged
@aorumbayev
Copy link
Contributor Author

@neilcampbell merged your spike and removed all usages of node specific utils. Have a few options to discuss around testing the debug package from utils-ts side, let's sync up on this tomorrow.

@aorumbayev aorumbayev force-pushed the feat/puya-debug branch 6 times, most recently from 67491bb to 55ccc79 Compare September 26, 2024 11:29
@aorumbayev aorumbayev force-pushed the feat/puya-debug branch 4 times, most recently from 4c34486 to c7d0d4f Compare September 26, 2024 12:04
@aorumbayev
Copy link
Contributor Author

@neilcampbell @robdmoore last couple of commits also add the following changes:

  • deprecating makerx/tsconfig in favour of tsconfig/node20
  • disabling console logs on jest which made it hard to navigate/monitor the ci runs -> when an error actually happens though it will print out stderr

neilcampbell
neilcampbell reviewed Sep 26, 2024
View reviewed changes
src/account/account.ts Show resolved Hide resolved
src/transaction/transaction.ts Outdated Show resolved Hide resolved
src/transaction/transaction.ts Outdated Show resolved Hide resolved
src/types/app-client.ts Outdated Show resolved Hide resolved
src/types/app-client.ts Outdated Show resolved Hide resolved
src/types/app.ts Outdated Show resolved Hide resolved
src/types/composer.ts Show resolved Hide resolved
src/types/composer.ts Show resolved Hide resolved
src/types/debugging.ts Outdated Show resolved Hide resolved
src/types/debugging.ts Show resolved Hide resolved
@aorumbayev aorumbayev marked this pull request as ready for review September 26, 2024 19:26
neilcampbell
neilcampbell reviewed Sep 27, 2024
View reviewed changes
docs/capabilities/debugging.md Outdated Show resolved Hide resolved
docs/capabilities/debugging.md Outdated Show resolved Hide resolved
docs/capabilities/event-emitter.md Outdated Show resolved Hide resolved
docs/capabilities/event-emitter.md Show resolved Hide resolved
src/types/async-event-emitter.spec.ts Outdated Show resolved Hide resolved
src/types/config.ts Outdated Show resolved Hide resolved
@aorumbayev aorumbayev merged commit 8687bed into main Sep 27, 2024
2 checks passed
@aorumbayev aorumbayev deleted the feat/puya-debug branch September 27, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilcampbell neilcampbell neilcampbell approved these changes

@robdmoore robdmoore Awaiting requested review from robdmoore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aorumbayev @neilcampbell