-
Notifications
You must be signed in to change notification settings - Fork 5
Added task to copier to warn that template is deprecated and updated … #76
Conversation
copier.yaml
Outdated
@@ -1,6 +1,10 @@ | |||
_subdirectory: template_content | |||
_templates_suffix: ".jinja" | |||
|
|||
_tasks: | |||
- "python -c \"print('WARNING: This template has been deprecated. Beaker for Algorand Smart Contract development is no longer supported.\\nPlease use Algorand Python instead. The Algorand Python template can be found at https://github.com/algorandfoundation/algokit-python-template')\"" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tasks runs before the init finishes but the files are still copied. Is there a way to run the tasks before prompting for the questions?
529d413
to
0b6d386
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre approving, please see my slightly different approach here first #77
845e90e
to
0618237
Compare
0618237
to
e9e7e37
Compare
@aorumbayev I saw your comment about testing it with the windows binary and I was finding that it wasn't deleting the template dir if you chose not to proceed after the deprecation warning. I added additional error logging and I am getting this error |
@lempira i see, yeah so this seems to be caused by the fact that the script running the deletion of the folder is located within that folder. There are several workarounds for this depending on whether you want to go an extra mile for this edge case or not:
|
05fd27b
to
a0b4eb3
Compare
a0b4eb3
to
159fe64
Compare
@lempira yeah makes sense, thats probably the most pragmatic, the windows binary is a fairly specific edge case not worth going overboard 👍 |
Proposed Changes