ARC-50: Delegated Asset Opt Ins #229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SudoWeezy
changed the title
jannotti
reviewed
Aug 4, 2023
|
|
||
| There are two logic signature programs that apply to this ARC. *Open Opt In Program* refers to a logic signature program that can be used by anyone to opt the signing account into any asset. *Address Opt In Delegation* refers to a logic signature program that can only be used by a specific account to opt the signing account into an asset. | ||
|
|
||
| Both logic signatures must be sent alongside an appcall to an app that implements a specific ABI method `openOptIn(pay,axfer)void` or `addressOptIn(pay,axfer)void`. These methods should determine whether the opt-in is allowed. |
There was a problem hiding this comment.
Why have the two methods? At one level, the reason is obvious - to constraint opt-ins to a given sender. But why is that particular check important enough to create complexity here? Isn't it the app's job to check things? It could check against a list of addresses, or it could not. Seems like the user signs this logicsig because it trusts the app to do the checking. Don't do any checking here.
|
Because of ARC59 (#285) I am withdrawing this ARC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A reference implementation can be seen here: https://github.com/joe-p/delegated_optin_arc/tree/main
This implementation will be added to the ARC repo and this ARC once it's reviewed and finalized.