-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better Router Mapping #689
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Zeph Grunschlag <[email protected]>
Co-authored-by: Zeph Grunschlag <[email protected]>
23 tasks
ahangsu
reviewed
Mar 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Walking across the weeds... I think I grasp a feeling of how this PR goes... leaving some comments for now
ahangsu
reviewed
Mar 17, 2023
ahangsu
reviewed
Mar 17, 2023
tzaffi
commented
Mar 17, 2023
ahangsu
approved these changes
Mar 17, 2023
tzaffi
commented
Mar 17, 2023
tzaffi
commented
Mar 17, 2023
tzaffi
commented
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with several tasks hilighted below, the PR improves the hit rate on router generated code by associating most of the previously unmatched lines to specific methods or bare calls. For example, you can see the improvement by looking at some of the diffs in this PR:
Other tasks from #681 which were completed
StackFrame - PyTealFrame - TealMapItem
hierarchy (Better Router Mapping #689)._sframes_container
are actually necessary. To see all usages: f96ef86STABLE_SLOT_GENERATION: bool
constants currentlyFalse
):_PyTealSourceMap._infer()
and see which lines are still being hit. Probably, there will be some situations that are no longer needed. (Better Router Mapping #689 tightened this up)Related PR's and Issues